Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exact match in wildcard #3446

Merged
merged 9 commits into from
Jul 15, 2022
Merged

Fix exact match in wildcard #3446

merged 9 commits into from
Jul 15, 2022

Conversation

glucaci
Copy link
Contributor

@glucaci glucaci commented Jul 14, 2022 •
edited
Loading

Fixes #3443.

@glucaci glucaci requested a review from a team as a code owner July 14, 2022 06:56
@glucaci glucaci changed the title Fix wildcard match Fix exact match in wildcard Jul 14, 2022
@codecov
Copy link

codecov bot commented Jul 14, 2022 •
edited
Loading

Codecov Report

Merging #3446 (bb663a2) into main (f471a9f) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3446      +/-   ##
==========================================
- Coverage   86.26%   86.25%   -0.02%     
==========================================
  Files         263      263              
  Lines        9545     9545              
==========================================
- Hits         8234     8233       -1     
- Misses       1311     1312       +1
Impacted Files Coverage Δ
src/OpenTelemetry/Internal/WildcardHelper.cs 88.88% <100.00%> (ø)
src/OpenTelemetry/Logs/OpenTelemetryLogger.cs 86.66% <0.00%> (-4.45%) ⬇️
...Telemetry/Internal/SelfDiagnosticsEventListener.cs 97.65% <0.00%> (+0.78%) ⬆️

reyang
reyang requested changes Jul 14, 2022
View reviewed changes
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/open-telemetry/opentelemetry-dotnet/pull/3446/files#r921378089

glucaci and others added 2 commits July 14, 2022 20:57
@glucaci glucaci requested a review from reyang July 14, 2022 18:58
@glucaci glucaci requested a review from Yun-Ting July 14, 2022 19:15
reyang
reyang approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a changelog entry.

@reyang reyang closed this Jul 14, 2022
@reyang reyang reopened this Jul 14, 2022
@glucaci
Copy link
Contributor Author

glucaci commented Jul 15, 2022

Please let me know if the changelog entry is good enough to understand the issue which was fixed.

@utpilla utpilla merged commit bc4f788 into open-telemetry:main Jul 15, 2022
@glucaci glucaci deleted the fixRegexPattern branch July 15, 2022 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yun-Ting Yun-Ting Yun-Ting approved these changes

@reyang reyang reyang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generated WildcardRegex will match substrigs of non registered sources.
4 participants
@glucaci @Yun-Ting @reyang @utpilla