[ASP.NET Core] Enable diagnostic source events using explicit names #3519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3519 +/- ##
==========================================
- Coverage 87.74% 87.64% -0.10%
==========================================
Files 283 283
Lines 10286 10296 +10
==========================================
- Hits 9025 9024 -1
- Misses 1261 1272 +11
|
…nosticSource-events
…nosticSource-events
alanwest
reviewed
Aug 2, 2022
src/OpenTelemetry.Instrumentation.AspNetCore/AspNetCoreInstrumentation.cs
Show resolved
Hide resolved
…nosticSource-events
…nosticSource-events
|
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
…nosticSource-events
…e-events' of https://github.com/vishweshbankwar/opentelemetry-dotnet into vibankwa/use-explicit-name-matching-for-diagnosticSource-events
|
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
…e-events' of https://github.com/vishweshbankwar/opentelemetry-dotnet into vibankwa/use-explicit-name-matching-for-diagnosticSource-events
…nosticSource-events
utpilla
approved these changes
Sep 20, 2022
…nosticSource-events
…nosticSource-events
cijothomas
reviewed
Sep 21, 2022
| | UninstrumentedAspNetCoreApp | 155.6 us | 2.63 us | 2.33 us | 0.9766 | 5 KB | | ||
| | InstrumentedAspNetCoreAppWithDefaultOptions | 176.8 us | 3.24 us | 2.70 us | 1.2207 | 7 KB | | ||
| | UninstrumentedAspNetCoreApp | 164.7 us | 1.66 us | 1.39 us | 0.9766 | 5 KB | | ||
| | InstrumentedAspNetCoreAppWithDefaultOptions | 178.7 us | 2.65 us | 2.35 us | 0.9766 | 5 KB | |
cijothomas
approved these changes
Sep 21, 2022
…e-events' of https://github.com/vishweshbankwar/opentelemetry-dotnet into vibankwa/use-explicit-name-matching-for-diagnosticSource-events
utpilla
reviewed
Sep 21, 2022
utpilla
approved these changes
Sep 21, 2022
|
@vishweshbankwar Hey I think this PR might have broken stuff. I'm testing the AspNetCore instrumentation using the example app. Not seeing any spans when running in net6.0. Took me a while but I got here:
Looks like a mismatch from what is being used vs what is defined? |
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #3495 .
Changes
This change will enable diagnostic source event subscription for asp.net core for the specified list of events.
ASP.NET Core library is using the best practices defined to write diagnostic source events.
Reference:
https://github.com/dotnet/aspnetcore/blob/main/src/Mvc/Mvc.Core/src/MvcCoreDiagnosticListenerExtensions.cs
https://github.com/dotnet/aspnetcore/blob/main/src/Hosting/Hosting/src/Internal/HostingApplicationDiagnostics.cs
This may also help with some perf as it will prevent the payload creation and writing of non-desired events.
Also, this can be extended to other instrumentation libraries based on DiagnosticSource events.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes