Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove netstandard targets from asp.netcore instrumentation #3567

Conversation

vishweshbankwar
Copy link
Member

@vishweshbankwar vishweshbankwar commented Aug 9, 2022

Fixes #.

Changes

As discussed during SIG meeting, removing netstandard2.0 and netstandard2.1 targets from the library.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #3567 (50fac81) into main (28473bc) will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3567      +/-   ##
==========================================
- Coverage   87.38%   87.23%   -0.15%     
==========================================
  Files         278      278              
  Lines       10088    10088              
==========================================
- Hits         8815     8800      -15     
- Misses       1273     1288      +15     
Impacted Files Coverage Δ
...tation.AspNetCore/Implementation/HttpInListener.cs 90.18% <ø> (ø)
...AspNetCore/Implementation/HttpInMetricsListener.cs 65.71% <ø> (ø)
...entation/ExportClient/OtlpGrpcTraceExportClient.cs 35.71% <0.00%> (-42.86%) ⬇️
...xporter.OpenTelemetryProtocol/OtlpTraceExporter.cs 36.36% <0.00%> (-40.91%) ⬇️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 73.52% <0.00%> (-5.89%) ⬇️
...metryProtocol/Implementation/ActivityExtensions.cs 91.20% <0.00%> (-4.40%) ⬇️
...nTelemetry/Internal/OpenTelemetrySdkEventSource.cs 76.66% <0.00%> (-0.84%) ⬇️
src/OpenTelemetry/BatchExportProcessor.cs 84.11% <0.00%> (+1.86%) ⬆️
src/OpenTelemetry/Logs/OpenTelemetryLogger.cs 88.88% <0.00%> (+2.22%) ⬆️
...tpListener/Internal/PrometheusCollectionManager.cs 80.48% <0.00%> (+2.43%) ⬆️
... and 3 more

@vishweshbankwar vishweshbankwar marked this pull request as ready for review August 9, 2022 21:24
@vishweshbankwar vishweshbankwar requested a review from a team as a code owner August 9, 2022 21:24
@vishweshbankwar vishweshbankwar changed the title Remove netstandard targets from asp.netcore Remove netstandard targets from asp.netcore instrumentation Aug 9, 2022
Copy link
Member

@alanwest alanwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vishweshbankwar
Copy link
Member Author

@utpilla - Can we merge this one before your release?

@utpilla utpilla merged commit 7fd9cb3 into open-telemetry:main Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants