Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Trace Exporters] Remove enumeration helper and use new net7 enumeration APIs #3580

Merged
merged 13 commits into from
Aug 18, 2022
Merged

[Trace Exporters] Remove enumeration helper and use new net7 enumeration APIs #3580

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
7f2767b
Remove enumeration helper and use new net7 enumeration APIs.
CodeBlanch Aug 16, 2022
18fae89
Bug fixes.
CodeBlanch Aug 16, 2022
e1d396d
Add note.
CodeBlanch Aug 16, 2022
d5c128b
Don't use list pools in OTLP exporter. Implement drop counts.
CodeBlanch Aug 16, 2022
203b9d0
Added asserts for drop counts in span limits test.
CodeBlanch Aug 16, 2022
21a41a9
Added issue link to skip text.
CodeBlanch Aug 16, 2022
6b260e8
Populate DroppedAttributesCount on links & events.
CodeBlanch Aug 16, 2022
a3f1d79
Code review.
CodeBlanch Aug 16, 2022
c7c4aa8
Code review.
CodeBlanch Aug 16, 2022
32905e1
Merge branch 'main' into enumeration-api-updates
CodeBlanch Aug 18, 2022
60d927f
Merge branch 'main' into enumeration-api-updates
CodeBlanch Aug 18, 2022
69f0b9d
Added CHANGELOG note about dropped counts.
CodeBlanch Aug 18, 2022
0acdb33
Merge branch 'main' into enumeration-api-updates
CodeBlanch Aug 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions build/Common.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
<SerilogPkgVer>[2.8.0,3.0)</SerilogPkgVer>
<StyleCopAnalyzersPkgVer>[1.2.0-beta.354,2.0)</StyleCopAnalyzersPkgVer>
<SystemCollectionsImmutablePkgVer>1.4.0</SystemCollectionsImmutablePkgVer>
<SystemDiagnosticSourcePkgVer>7.0.0-preview.4.22229.4</SystemDiagnosticSourcePkgVer>
<SystemDiagnosticSourcePkgVer>7.0.0-preview.7.22375.6</SystemDiagnosticSourcePkgVer>
<SystemReflectionEmitLightweightPkgVer>4.7.0</SystemReflectionEmitLightweightPkgVer>
<SystemTextJsonPkgVer>4.7.0</SystemTextJsonPkgVer>
<SystemThreadingTasksExtensionsPkgVer>4.5.3</SystemThreadingTasksExtensionsPkgVer>
Expand Down Expand Up @@ -74,9 +74,7 @@

<ItemGroup Condition="'$(IncludeInstrumentationHelpers)'=='true' Or '$(IncludeDiagnosticSourceInstrumentationHelpers)'=='true'">
<Compile Include="$(RepoRoot)\src\OpenTelemetry.Api\Internal\ActivityHelperExtensions.cs" Link="Includes\ActivityHelperExtensions.cs" />
<Compile Include="$(RepoRoot)\src\OpenTelemetry.Api\Internal\EnumerationHelper.cs" Link="Includes\EnumerationHelper.cs" />
<Compile Include="$(RepoRoot)\src\OpenTelemetry.Api\Internal\ExceptionExtensions.cs" Link="Includes\ExceptionExtensions.cs" />
<Compile Include="$(RepoRoot)\src\OpenTelemetry.Api\Internal\IActivityEnumerator.cs" Link="Includes\IActivityEnumerator.cs" />
<Compile Include="$(RepoRoot)\src\OpenTelemetry.Api\Internal\SemanticConventions.cs" Link="Includes\SemanticConventions.cs" />
<Compile Include="$(RepoRoot)\src\OpenTelemetry.Api\Internal\SpanAttributeConstants.cs" Link="Includes\SpanAttributeConstants.cs" />
<Compile Include="$(RepoRoot)\src\OpenTelemetry.Api\Internal\SpanHelper.cs" Link="Includes\SpanHelper.cs" />
Expand Down
399 changes: 42 additions & 357 deletions src/OpenTelemetry.Api/Internal/ActivityHelperExtensions.cs
View file
Open in desktop

Large diffs are not rendered by default.

181 changes: 0 additions & 181 deletions src/OpenTelemetry.Api/Internal/EnumerationHelper.cs
View file
Open in desktop

This file was deleted.

34 changes: 0 additions & 34 deletions src/OpenTelemetry.Api/Internal/IActivityEnumerator.cs
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion src/OpenTelemetry.Api/OpenTelemetry.Api.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,5 @@

<ItemGroup>
<PackageReference Include="System.Diagnostics.DiagnosticSource" Version="$(SystemDiagnosticSourcePkgVer)" />
<PackageReference Include="System.Reflection.Emit.Lightweight" Version="$(SystemReflectionEmitLightweightPkgVer)" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

</ItemGroup>
</Project>
Loading