Support UpDownCounter and ObservableUpDownCounter #3606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3606 +/- ##
==========================================
- Coverage 87.33% 87.29% -0.05%
==========================================
Files 280 280
Lines 10066 10081 +15
==========================================
+ Hits 8791 8800 +9
- Misses 1275 1281 +6
|
alanwest
commented
Aug 31, 2022
reyang
reviewed
Sep 1, 2022
reyang
reviewed
Sep 1, 2022
reyang
reviewed
Sep 1, 2022
test/OpenTelemetry.Exporter.Prometheus.Tests/PrometheusSerializerTests.cs
Outdated
Show resolved
Hide resolved
reyang
reviewed
Sep 1, 2022
| exportedItems.Clear(); | ||
|
|
||
| #if NETFRAMEWORK | ||
| Thread.Sleep(5000); // Compensates for low resolution timing in netfx. |
There was a problem hiding this comment.
Curious, why 5000 (this is a very long time from the CPU's perspective)?
There was a problem hiding this comment.
CPUs always want things right now! They oughta learn to have some patience.
But, yea you're right... I decreased it to 10 ms and also decreased it from the test I borrowed this from.
reyang
approved these changes
Sep 1, 2022
cijothomas
reviewed
Sep 2, 2022
| @@ -25,7 +25,7 @@ internal static partial class PrometheusSerializer | |||
| { | |||
| private static readonly string[] MetricTypes = new string[] | |||
| { | |||
| "untyped", "counter", "gauge", "summary", "histogram", "histogram", "histogram", "histogram", "untyped", | |||
| "untyped", "counter", "gauge", "summary", "histogram", "histogram", "histogram", "histogram", "gauge", | |||
There was a problem hiding this comment.
TODO: it might be good add a comment here to explain why. (like UpDownCounters are exported as Prometheus Gauge etc.)
cijothomas
reviewed
Sep 2, 2022
| var attributes = ToAttributes(keysValues).ToArray(); | ||
| if (longValue.HasValue) | ||
| { | ||
| var counter = meter.CreateUpDownCounter<long>(name, unit, description); |
There was a problem hiding this comment.
nit: var counterUpDownCounter
cijothomas
reviewed
Sep 2, 2022
| [Theory] | ||
| [InlineData(true)] | ||
| [InlineData(false)] | ||
| public void ObservableUpDownCounterWithTagsAggregationTest(bool exportDelta) |
There was a problem hiding this comment.
TODO: why UpDownCounterWithTagsAggregationTest is missing?
cijothomas
approved these changes
Sep 2, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for aggregating measurements from UpDownCounters. Includes updates to OTLP and Prometheus exporters.