Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.3.1 patch] Update CHANGELOG with the new issue #3630

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Sep 6, 2022

@utpilla utpilla requested a review from a team as a code owner September 6, 2022 22:54
* Metrics removed as it is not part 1.0.0 release. See issue [#1501](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1655)
for details on Metric release plans.
* Metrics removed as it is not part 1.0.0 release. See issue
[#1501](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1655) for
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text and link are actually pointing to two different locations?

@@ -100,10 +108,12 @@ Released 2021-Aug-24

Released 2021-Jul-23

* Add Metrics support.([#2174](https://github.com/open-telemetry/opentelemetry-dotnet/pull/2174))
* Add Metrics
support.([#2174](https://github.com/open-telemetry/opentelemetry-dotnet/pull/2174))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this missed a space:

Suggested change
support.([#2174](https://github.com/open-telemetry/opentelemetry-dotnet/pull/2174))
support. ([#2174](https://github.com/open-telemetry/opentelemetry-dotnet/pull/2174))

Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@utpilla
Copy link
Contributor Author

utpilla commented Sep 6, 2022

Closing this in favor of #3631

@utpilla utpilla closed this Sep 6, 2022
@utpilla utpilla deleted the utpilla/Update-CHANGELOG-with-issue branch November 3, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants