Support Prometheus UNIT metadata #3651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3651 +/- ##
==========================================
+ Coverage 87.58% 87.60% +0.02%
==========================================
Files 283 283
Lines 10218 10234 +16
==========================================
+ Hits 8949 8966 +17
+ Misses 1269 1268 -1
|
reyang
added
pkg:OpenTelemetry.Exporter.Prometheus.AspNetCore
cijothomas
reviewed
Sep 13, 2022
| .AddInMemoryExporter(metrics) | ||
| .Build(); | ||
|
|
||
| meter.CreateObservableGauge("test_gauge", () => 123, unit: "seconds", description: "Hello, world!"); |
There was a problem hiding this comment.
Needs some clever Greek mythology thing. Defer to @alanwest to come up with it 🤣
There was a problem hiding this comment.
I mean, would "Hello, Prometheus!" not have been clever enough? And also what the heck do I know about Greek mythology?
There was a problem hiding this comment.
Do we consider the Prometheus Exporters to be renamed to OpenMetrics Exporters? 😆
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Reference: https://github.com/OpenObservability/OpenMetrics/blob/main/specification/OpenMetrics.md#overall-structure
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes