Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Traces] Support named options in HttpWebRequest instrumentation #3667

Merged

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Sep 15, 2022

Changes

TODOs

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Unit tests
  • Changes in public API reviewed

@CodeBlanch CodeBlanch requested a review from a team as a code owner September 15, 2022 18:22
@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #3667 (7e57945) into main (215f58b) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3667   +/-   ##
=======================================
  Coverage   87.72%   87.73%           
=======================================
  Files         283      283           
  Lines       10286    10286           
=======================================
+ Hits         9023     9024    +1     
+ Misses       1263     1262    -1     
Impacted Files Coverage Δ
...umentation.Http/TracerProviderBuilderExtensions.cs 100.00% <ø> (ø)
...Telemetry/Internal/SelfDiagnosticsEventListener.cs 96.87% <0.00%> (-0.79%) ⬇️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 79.41% <0.00%> (+5.88%) ⬆️

@CodeBlanch CodeBlanch merged commit d72a94f into open-telemetry:main Sep 15, 2022
@CodeBlanch CodeBlanch deleted the httpwebrequest-namedoptions branch September 15, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants