Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Diagnostic Source to rc version #3698

Merged

Conversation

vishweshbankwar
Copy link
Member

@vishweshbankwar vishweshbankwar commented Sep 27, 2022

Fixes #.

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@vishweshbankwar vishweshbankwar marked this pull request as ready for review September 27, 2022 02:37
@vishweshbankwar vishweshbankwar requested a review from a team as a code owner September 27, 2022 02:37
@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #3698 (f70fec5) into main (8800b2f) will increase coverage by 0.23%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3698      +/-   ##
==========================================
+ Coverage   87.54%   87.77%   +0.23%     
==========================================
  Files         283      283              
  Lines       10308    10308              
==========================================
+ Hits         9024     9048      +24     
+ Misses       1284     1260      -24     
Impacted Files Coverage Δ
...tation/OpenTelemetryProtocolExporterEventSource.cs 75.00% <0.00%> (-10.00%) ⬇️
...Listener/Internal/PrometheusExporterEventSource.cs 61.11% <0.00%> (-5.56%) ⬇️
...tpListener/Internal/PrometheusCollectionManager.cs 72.52% <0.00%> (-2.20%) ⬇️
...metryProtocol/Implementation/ActivityExtensions.cs 95.05% <0.00%> (+3.29%) ⬆️
src/OpenTelemetry/Logs/Pool/LogRecordSharedPool.cs 100.00% <0.00%> (+21.05%) ⬆️
...xporter.OpenTelemetryProtocol/OtlpTraceExporter.cs 77.27% <0.00%> (+40.90%) ⬆️
...entation/ExportClient/OtlpGrpcTraceExportClient.cs 78.57% <0.00%> (+42.85%) ⬆️

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog for api project too

@utpilla utpilla merged commit 86ee906 into open-telemetry:main Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants