[Exporter.PrometheusAspNetCore] update Public API #3717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kielek
force-pushed
the
prometheusaspnetcore-exporter-update-public-api
branch
from
00c7fab
to
2506e06
Compare
Kielek
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3717 +/- ##
==========================================
- Coverage 87.32% 87.08% -0.24%
==========================================
Files 274 275 +1
Lines 10009 10012 +3
==========================================
- Hits 8740 8719 -21
- Misses 1269 1293 +24
|
reyang
approved these changes
Sep 30, 2022
|
@open-telemetry/dotnet-maintainers please check and possibly merge. |
utpilla
reviewed
Oct 4, 2022
| @@ -51,5 +52,7 @@ public IReadOnlyCollection<string> UriPrefixes | |||
| this.uriPrefixes = value; | |||
| } | |||
| } | |||
|
|
|||
| internal PrometheusExporterOptions ExporterOptions { get; } = new(); | |||
Fixed: db2f4fc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public API changes from #3694 proposed by @CodeBlanch.
Changes
It will allow us to add more properties later for all Prometheus exporters.
There is no stable release for this package, so it should be fine to adjust class name.
CHANGELOG.mdupdated for non-trivial changes[ ] Design discussion issue #