Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASP.NET Core] Add additional http.server.duration metric attributes #3928

Conversation

vishweshbankwar
Copy link
Member

@vishweshbankwar vishweshbankwar commented Nov 21, 2022

Towards #3373

Changes

As per spec https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/semantic_conventions/http-metrics.md#attributes

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@vishweshbankwar vishweshbankwar marked this pull request as ready for review November 21, 2022 17:34
@vishweshbankwar vishweshbankwar requested a review from a team as a code owner November 21, 2022 17:34
@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Merging #3928 (6f04ce8) into main (a4df145) will decrease coverage by 0.01%.
The diff coverage is 90.90%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3928      +/-   ##
==========================================
- Coverage   87.40%   87.39%   -0.02%     
==========================================
  Files         278      278              
  Lines       10757    10747      -10     
==========================================
- Hits         9402     9392      -10     
  Misses       1355     1355              
Impacted Files Coverage Δ
...AspNetCore/Implementation/HttpInMetricsListener.cs 84.00% <90.90%> (+18.28%) ⬆️
...porter.OpenTelemetryProtocol/OtlpMetricExporter.cs 72.72% <0.00%> (-13.64%) ⬇️
...tation/OpenTelemetryProtocolExporterEventSource.cs 85.00% <0.00%> (-10.00%) ⬇️
...ZPages/Implementation/ZPagesExporterEventSource.cs 56.25% <0.00%> (-6.25%) ⬇️
...p/Implementation/HttpInstrumentationEventSource.cs 72.00% <0.00%> (-4.00%) ⬇️
...Telemetry/Internal/SelfDiagnosticsEventListener.cs 96.87% <0.00%> (-0.79%) ⬇️

@utpilla utpilla merged commit c5ecd05 into open-telemetry:main Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants