Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update value of the resource attribute telemetry.sdk.version #4375

Merged

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Apr 6, 2023

Changes

  • Update value of the resource attribute telemetry.sdk.version to show the tag name (which resembles the package version) instead of showing version number with revision

Current behavior:

  • If you use, 1.4.0 version of the SDK, the value logged for telemetry.sdk.version is 1.4.0.802
  • If you use, 1.4.0-rc.4 version of the SDK, the value logged for telemetry.sdk.version is 1.4.0.788

With this PR:

  • If you use, 1.4.0 version of the SDK, the value logged for telemetry.sdk.version is 1.4.0
  • If you use, 1.4.0-rc.4 version of the SDK, the value logged for telemetry.sdk.version is 1.4.0-rc.4

Note: You would see this behavior going forward once we start to make newer releases.

  • Appropriate CHANGELOG.md files updated for non-trivial changes

@utpilla utpilla requested a review from a team as a code owner April 6, 2023 23:36
@utpilla utpilla changed the title Update value of the resource attribute Telemetry SDK version Update value of the resource attribute telemetry.sdk.version Apr 6, 2023
@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #4375 (ad4b666) into main (807f703) will decrease coverage by 0.03%.
The diff coverage is 83.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4375      +/-   ##
==========================================
- Coverage   84.74%   84.72%   -0.03%     
==========================================
  Files         300      300              
  Lines       12006    12010       +4     
==========================================
  Hits        10175    10175              
- Misses       1831     1835       +4     
Impacted Files Coverage Δ
...enTelemetry/Resources/ResourceBuilderExtensions.cs 90.62% <83.33%> (-2.24%) ⬇️

... and 5 files with indirect coverage changes

@reyang
Copy link
Member

reyang commented Apr 7, 2023

A non-blocking question - is there a way to show the difference when this is running from a local build (potentially with code changes that are not yet committed)?

@utpilla
Copy link
Contributor Author

utpilla commented Apr 7, 2023

A non-blocking question - is there a way to show the difference when this is running from a local build (potentially with code changes that are not yet committed)?

When you run this from a local build (assuming you haven't added a new tag at the current commit), it would include Git Height either after the patchVersion or after the preReleaseVersion. This is what it logs when I run it from this feature branch:

telemetry.sdk.version: 1.5.0-alpha.1.41

That ".41" is the git height which would otherwise be missing if you used a NuGet package (stable/prerelease).

@utpilla utpilla merged commit bf9f07d into open-telemetry:main Apr 7, 2023
29 checks passed
Kielek added a commit to Kielek/opentelemetry-dotnet-instrumentation that referenced this pull request Jun 9, 2023
Kielek added a commit to open-telemetry/opentelemetry-dotnet-instrumentation that referenced this pull request Jun 9, 2023
* Bump OpenTelemetry from 1.4.0 to 1.5.0

Bumps [OpenTelemetry](https://github.com/open-telemetry/opentelemetry-dotnet) from 1.4.0 to 1.5.0.
- [Release notes](https://github.com/open-telemetry/opentelemetry-dotnet/releases)
- [Commits](open-telemetry/opentelemetry-dotnet@core-1.4.0...core-1.5.0)

---
updated-dependencies:
- dependency-name: OpenTelemetry
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump OpenTelemetry.Api from 1.4.0 to 1.5.0

Bumps [OpenTelemetry.Api](https://github.com/open-telemetry/opentelemetry-dotnet) from 1.4.0 to 1.5.0.
- [Release notes](https://github.com/open-telemetry/opentelemetry-dotnet/releases)
- [Commits](open-telemetry/opentelemetry-dotnet@core-1.4.0...core-1.5.0)

---
updated-dependencies:
- dependency-name: OpenTelemetry.Api
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump OpenTelemetry.Extensions.Propagators from 1.4.0 to 1.5.0

Bumps [OpenTelemetry.Extensions.Propagators](https://github.com/open-telemetry/opentelemetry-dotnet) from 1.4.0 to 1.5.0.
- [Release notes](https://github.com/open-telemetry/opentelemetry-dotnet/releases)
- [Commits](open-telemetry/opentelemetry-dotnet@core-1.4.0...core-1.5.0)

---
updated-dependencies:
- dependency-name: OpenTelemetry.Extensions.Propagators
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump OpenTelemetry.Exporter.OpenTelemetryProtocol from 1.4.0 to 1.5.0

Bumps [OpenTelemetry.Exporter.OpenTelemetryProtocol](https://github.com/open-telemetry/opentelemetry-dotnet) from 1.4.0 to 1.5.0.
- [Release notes](https://github.com/open-telemetry/opentelemetry-dotnet/releases)
- [Commits](open-telemetry/opentelemetry-dotnet@core-1.4.0...core-1.5.0)

---
updated-dependencies:
- dependency-name: OpenTelemetry.Exporter.OpenTelemetryProtocol
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump OpenTelemetry.Exporter.Zipkin from 1.4.0 to 1.5.0

Bumps [OpenTelemetry.Exporter.Zipkin](https://github.com/open-telemetry/opentelemetry-dotnet) from 1.4.0 to 1.5.0.
- [Release notes](https://github.com/open-telemetry/opentelemetry-dotnet/releases)
- [Commits](open-telemetry/opentelemetry-dotnet@core-1.4.0...core-1.5.0)

---
updated-dependencies:
- dependency-name: OpenTelemetry.Exporter.Zipkin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump OpenTelemetry.Exporter.Console from 1.4.0 to 1.5.0

Bumps [OpenTelemetry.Exporter.Console](https://github.com/open-telemetry/opentelemetry-dotnet) from 1.4.0 to 1.5.0.
- [Release notes](https://github.com/open-telemetry/opentelemetry-dotnet/releases)
- [Commits](open-telemetry/opentelemetry-dotnet@core-1.4.0...core-1.5.0)

---
updated-dependencies:
- dependency-name: OpenTelemetry.Exporter.Console
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump OpenTelemetry.Instrumentation.Runtime from 1.4.0 to 1.5.0

Bumps [OpenTelemetry.Instrumentation.Runtime](https://github.com/open-telemetry/opentelemetry-dotnet-contrib) from 1.4.0 to 1.5.0.
- [Release notes](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/releases)
- [Commits](open-telemetry/opentelemetry-dotnet-contrib@Exporter.Geneva-1.4.0...Instrumentation.Runtime-1.5.0)

---
updated-dependencies:
- dependency-name: OpenTelemetry.Instrumentation.Runtime
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump OpenTelemetry.Instrumentation.AspNet

Bumps [OpenTelemetry.Instrumentation.AspNet](https://github.com/open-telemetry/opentelemetry-dotnet-contrib) from 1.0.0-rc9.8 to 1.0.0-rc9.9.
- [Release notes](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/releases)
- [Commits](open-telemetry/opentelemetry-dotnet-contrib@Instrumentation.AspNet-1.0.0-rc9.8...Instrumentation.AspNet-1.0.0-rc9.9)

---
updated-dependencies:
- dependency-name: OpenTelemetry.Instrumentation.AspNet
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump OpenTelemetry.Instrumentation.StackExchangeRedis

Bumps [OpenTelemetry.Instrumentation.StackExchangeRedis](https://github.com/open-telemetry/opentelemetry-dotnet-contrib) from 1.0.0-rc9.9 to 1.0.0-rc9.10.
- [Release notes](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/releases)
- [Commits](open-telemetry/opentelemetry-dotnet-contrib@Instrumentation.AspNet-1.0.0-rc9.9...Instrumentation.StackExchangeRedis-1.0.0-rc9.10)

---
updated-dependencies:
- dependency-name: OpenTelemetry.Instrumentation.StackExchangeRedis
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump OpenTelemetry.Instrumentation.Wcf from 1.0.0-rc.9 to 1.0.0-rc.10

Bumps [OpenTelemetry.Instrumentation.Wcf](https://github.com/open-telemetry/opentelemetry-dotnet-contrib) from 1.0.0-rc.9 to 1.0.0-rc.10.
- [Release notes](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/releases)
- [Commits](open-telemetry/opentelemetry-dotnet-contrib@Instrumentation.Wcf-1.0.0-rc.9...Instrumentation.Wcf-1.0.0-rc.10)

---
updated-dependencies:
- dependency-name: OpenTelemetry.Instrumentation.Wcf
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump OpenTelemetry.ResourceDetectors.Container

Bumps [OpenTelemetry.ResourceDetectors.Container](https://github.com/open-telemetry/opentelemetry-dotnet-contrib) from 1.0.0-beta.3 to 1.0.0-beta.4.
- [Release notes](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/releases)
- [Commits](open-telemetry/opentelemetry-dotnet-contrib@Extensions-1.0.0-beta.3...Extensions-1.0.0-beta.4)

---
updated-dependencies:
- dependency-name: OpenTelemetry.ResourceDetectors.Container
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump OpenTelemetry.Instrumentation.EntityFrameworkCore

Bumps [OpenTelemetry.Instrumentation.EntityFrameworkCore](https://github.com/open-telemetry/opentelemetry-dotnet-contrib) from 1.0.0-beta.6 to 1.0.0-beta.7.
- [Release notes](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/releases)
- [Commits](open-telemetry/opentelemetry-dotnet-contrib@Instrumentation.MySqlData-1.0.0-beta.6...Instrumentation.MySqlData-1.0.0-beta.7)

---
updated-dependencies:
- dependency-name: OpenTelemetry.Instrumentation.EntityFrameworkCore
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump OpenTelemetry.Instrumentation.Quartz

Bumps [OpenTelemetry.Instrumentation.Quartz](https://github.com/open-telemetry/opentelemetry-dotnet-contrib) from 1.0.0-alpha.2 to 1.0.0-alpha.3.
- [Release notes](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/releases)
- [Commits](open-telemetry/opentelemetry-dotnet-contrib@Instrumentation.Quartz-1.0.0-alpha.2...Instrumentation.Quartz-1.0.0-alpha.3)

---
updated-dependencies:
- dependency-name: OpenTelemetry.Instrumentation.Quartz
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump OpenTelemetry.Instrumentation.MySqlData

Bumps [OpenTelemetry.Instrumentation.MySqlData](https://github.com/open-telemetry/opentelemetry-dotnet-contrib) from 1.0.0-beta.6 to 1.0.0-beta.7.
- [Release notes](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/releases)
- [Commits](open-telemetry/opentelemetry-dotnet-contrib@Instrumentation.MySqlData-1.0.0-beta.6...Instrumentation.MySqlData-1.0.0-beta.7)

---
updated-dependencies:
- dependency-name: OpenTelemetry.Instrumentation.MySqlData
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump OpenTelemetry.Instrumentation.Process

Bumps [OpenTelemetry.Instrumentation.Process](https://github.com/open-telemetry/opentelemetry-dotnet-contrib) from 0.5.0-beta.2 to 0.5.0-beta.3.
- [Release notes](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/releases)
- [Commits](open-telemetry/opentelemetry-dotnet-contrib@Instrumentation.Process-0.5.0-beta.2...Instrumentation.Process-0.5.0-beta.3)

---
updated-dependencies:
- dependency-name: OpenTelemetry.Instrumentation.Process
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update packages without dependabot PRs

* assembly redirection

* Update plugin documentation

* Update changelog

* Update documentation after OTel bump

* Update expected telemetry.sdk.version value
open-telemetry/opentelemetry-dotnet#4375

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@utpilla utpilla deleted the utpilla/Update-Resource-SdkVersion branch November 3, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants