Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASP.NET Core] Fix System.Text.Encodings.Web vulnerability #4399

Conversation

vishweshbankwar
Copy link
Member

@vishweshbankwar vishweshbankwar commented Apr 18, 2023

Follow up to #4390 (comment)

There is no version available for Microsoft.AspNetCore.Http.Abstractions with System.Text.Encodings.Web dependency >=4.7.2. That is why adding a direct reference.

Design discussion issue #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #4399 (9668c8d) into main (586aa7e) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 9668c8d differs from pull request most recent head 2cae6a3. Consider uploading reports for the commit 2cae6a3 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4399   +/-   ##
=======================================
  Coverage   84.77%   84.77%           
=======================================
  Files         300      300           
  Lines       12010    12010           
=======================================
+ Hits        10181    10182    +1     
+ Misses       1829     1828    -1     

see 5 files with indirect coverage changes

@vishweshbankwar vishweshbankwar marked this pull request as ready for review April 18, 2023 15:13
@vishweshbankwar vishweshbankwar requested a review from a team as a code owner April 18, 2023 15:13
@utpilla utpilla merged commit bfb3e45 into open-telemetry:main Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants