Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update semantic conventions for grpc client #4658

Conversation

vishweshbankwar
Copy link
Member

@vishweshbankwar vishweshbankwar commented Jul 14, 2023

Towards #4484
Design discussion issue #

• update the GRPC client library attributes.
net.peer.ip -> server.socket.address
net.peer.name -> server.address
net.peer.port -> server.port

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@vishweshbankwar
Copy link
Member Author

@TimothyMothra Would you be able to add changelog and comments to this as part of your PR?

@vishweshbankwar vishweshbankwar marked this pull request as ready for review July 14, 2023 18:55
@vishweshbankwar vishweshbankwar requested a review from a team as a code owner July 14, 2023 18:55
@TimothyMothra
Copy link
Contributor

@vishweshbankwar please update the description here describing what attributes changed.
This was asked to help reviewers understand the changes.
See any of my previous PR for an example

@TimothyMothra
Copy link
Contributor

@TimothyMothra Would you be able to add changelog and comments to this as part of your PR?

I updated the grpc changelog in my PR #4659.

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #4658 (da94d88) into main (4a3b97f) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4658      +/-   ##
==========================================
- Coverage   85.08%   84.97%   -0.11%     
==========================================
  Files         314      314              
  Lines       12715    12723       +8     
==========================================
- Hits        10819    10812       -7     
- Misses       1896     1911      +15     
Impacted Files Coverage Δ
...ent/Implementation/GrpcClientDiagnosticListener.cs 88.23% <100.00%> (+1.56%) ⬆️

... and 5 files with indirect coverage changes

@utpilla utpilla merged commit 91217ba into open-telemetry:main Jul 14, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants