Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Enrich and Filter for ASP.NET Core metrics #4981

Conversation

vishweshbankwar
Copy link
Member

@vishweshbankwar vishweshbankwar commented Oct 23, 2023

Towards #open-telemetry/opentelemetry-dotnet-contrib#1733
Design discussion issue #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #4981 (3279180) into main (d07d030) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    open-telemetry/opentelemetry-dotnet#4981      +/-   ##
==========================================
+ Coverage   83.34%   83.41%   +0.06%     
==========================================
  Files         295      295              
  Lines       12378    12336      -42     
==========================================
- Hits        10317    10290      -27     
+ Misses       2061     2046      -15     
Flag Coverage Δ
unittests 83.41% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...NetCore/AspNetCoreMetricsInstrumentationOptions.cs 60.00% <ø> (-11.43%) ⬇️
...ementation/AspNetCoreInstrumentationEventSource.cs 70.00% <ø> (-2.73%) ⬇️
...AspNetCore/Implementation/HttpInMetricsListener.cs 86.79% <ø> (+15.90%) ⬆️
...ation.AspNetCore/MeterProviderBuilderExtensions.cs 100.00% <100.00%> (+5.40%) ⬆️

... and 4 files with indirect coverage changes

@vishweshbankwar vishweshbankwar marked this pull request as ready for review October 23, 2023 17:09
@vishweshbankwar vishweshbankwar requested a review from a team as a code owner October 23, 2023 17:09
vishweshbankwar and others added 2 commits October 23, 2023 10:24
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
@vishweshbankwar
Copy link
Member Author

referencing the original PR where these options were added #3948

@Temppus FYI

vishweshbankwar and others added 2 commits October 23, 2023 12:55
…InstrumentationOptions.cs

Co-authored-by: Utkarsh Umesan Pillai <66651184+utpilla@users.noreply.github.com>
vishweshbankwar and others added 3 commits October 23, 2023 13:59
Co-authored-by: Mikel Blanchard <mblanchard@macrosssoftware.com>
@CodeBlanch CodeBlanch merged commit faa70be into open-telemetry:main Oct 23, 2023
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants