Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check isSampled parameter in UpdateWithExemplar method #5004

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Check isSampled parameter in UpdateWithExemplar method #5004

merged 3 commits into from
Oct 31, 2023

Conversation

ImoutoChan
Copy link
Contributor

@ImoutoChan ImoutoChan commented Oct 28, 2023

Fixes #4851

Changes

Check isSampled parameter in UpdateWithExemplar method before each call to ExemplarReservoir!.Offer

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Appropriate CHANGELOG.md files updated for non-trivial changes

@ImoutoChan ImoutoChan requested a review from a team as a code owner October 28, 2023 08:49
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 28, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@cijothomas
Copy link
Member

@ImoutoChan Thanks! Could you add an entry to the changelog file as this is a bug fix?

@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

Merging #5004 (a4bd3dd) into main (86a6ba0) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5004   +/-   ##
=======================================
  Coverage   83.37%   83.38%           
=======================================
  Files         295      295           
  Lines       12339    12343    +4     
=======================================
+ Hits        10288    10292    +4     
  Misses       2051     2051           
Flag Coverage Δ
unittests 83.38% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/OpenTelemetry/Metrics/MetricPoint.cs 68.47% <0.00%> (-0.54%) ⬇️

... and 5 files with indirect coverage changes

@ImoutoChan
Copy link
Contributor Author

@cijothomas sure

@utpilla utpilla merged commit b45b8a9 into open-telemetry:main Oct 31, 2023
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MetricPoint.UpdateWithExemplar method honors isSampled parameter only for DoubleSumIncomingDelta case
3 participants