Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpClient] update network.protocol.version values as per specification #5006

Conversation

vishweshbankwar
Copy link
Member

@vishweshbankwar vishweshbankwar commented Oct 30, 2023

Fixes #
Design discussion issue #

Changes

Assign values as per spec https://github.com/open-telemetry/semantic-conventions/blob/main/docs/http/http-spans.md#common-attributes

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #5006 (48f2776) into main (4ccee25) will decrease coverage by 0.19%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5006      +/-   ##
==========================================
- Coverage   83.52%   83.33%   -0.19%     
==========================================
  Files         296      296              
  Lines       12467    12475       +8     
==========================================
- Hits        10413    10396      -17     
- Misses       2054     2079      +25     
Flag Coverage Δ
unittests 83.33% <66.66%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...tp/Implementation/HttpHandlerDiagnosticListener.cs 73.50% <100.00%> (ø)
...ementation/HttpHandlerMetricsDiagnosticListener.cs 90.14% <100.00%> (ø)
...plementation/HttpWebRequestActivitySource.netfx.cs 82.71% <100.00%> (ø)
...strumentation.Http/Implementation/HttpTagHelper.cs 85.18% <50.00%> (-14.82%) ⬇️

... and 7 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Nov 7, 2023

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions bot added the Stale label Nov 7, 2023
@vishweshbankwar vishweshbankwar changed the title [HttpClient] fix network.protocol.version [HttpClient] update network.protocol.version values as per specification Nov 10, 2023
@vishweshbankwar vishweshbankwar marked this pull request as ready for review November 10, 2023 00:26
@vishweshbankwar vishweshbankwar requested a review from a team as a code owner November 10, 2023 00:26
@github-actions github-actions bot removed the Stale label Nov 10, 2023
@utpilla utpilla merged commit 6637308 into open-telemetry:main Nov 10, 2023
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants