Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASP.NET Core] update network.protocol.version values as per spec #5007

Conversation

vishweshbankwar
Copy link
Member

@vishweshbankwar vishweshbankwar commented Oct 30, 2023

Fixes #
Design discussion issue #

Changes

Assign values as per spec https://github.com/open-telemetry/semantic-conventions/blob/main/docs/http/http-spans.md#common-attributes

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #5007 (9d65736) into main (b7bc57b) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

❗ Current head 9d65736 differs from pull request most recent head aa9c92f. Consider uploading reports for the commit aa9c92f to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5007      +/-   ##
==========================================
- Coverage   83.38%   83.37%   -0.01%     
==========================================
  Files         296      296              
  Lines       12467    12467              
==========================================
- Hits        10395    10394       -1     
- Misses       2072     2073       +1     
Flag Coverage Δ
unittests 83.37% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ntation.AspNetCore/Implementation/HttpTagHelper.cs 50.00% <50.00%> (ø)

... and 2 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Nov 9, 2023

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions bot added the Stale label Nov 9, 2023
@vishweshbankwar vishweshbankwar marked this pull request as ready for review November 9, 2023 23:47
@vishweshbankwar vishweshbankwar requested a review from a team as a code owner November 9, 2023 23:47
@vishweshbankwar vishweshbankwar changed the title [ASP.NET Core] Fix network.protocol.version [ASP.NET Core] update network.protocol.version values as per spec Nov 9, 2023
@utpilla utpilla merged commit 4ccee25 into open-telemetry:main Nov 10, 2023
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants