[Exemplars] Add isSampled check for Histograms #5016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5016 +/- ##
==========================================
- Coverage 83.41% 83.39% -0.02%
==========================================
Files 296 296
Lines 12377 12377
==========================================
- Hits 10324 10322 -2
- Misses 2053 2055 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
cijothomas
reviewed
Nov 2, 2023
| | HistogramWithTagReduction | AlwaysOff | 298.9 ns | 2.44 ns | 2.16 ns | | ||
| | HistogramNoTagReduction | AlwaysOn | 359.6 ns | 1.26 ns | 1.11 ns | | ||
| | HistogramWithTagReduction | AlwaysOn | 400.1 ns | 4.16 ns | 3.90 ns | | ||
| | HistogramNoTagReduction | HighValueOnly | 325.3 ns | 3.33 ns | 2.78 ns | |
There was a problem hiding this comment.
💯 ! Thanks for fixing this! I was discussing last week why the perf was not improving a lot despite the Filter!
cijothomas
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
isSampledcheck for Histogram updates so that we call ExemplarReservoir only when the ExemplarFilter samples the measurementMerge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes