Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpClient and ASP.NET Core] Fix failures due to changes in .NET8.0 stable release #5049

Merged

Conversation

vishweshbankwar
Copy link
Member

@vishweshbankwar vishweshbankwar commented Nov 14, 2023

Fixes #
Design discussion issue #

Changes

Fixes couple of failures due to upgrade to .NET8.0. These are expected changes based on the issues that were fixed between rc and table release.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@vishweshbankwar vishweshbankwar changed the title Fix failures due to changes in .NET8.0 stable release [HttpClient and ASP.NET Core] Fix failures due to changes in .NET8.0 stable release Nov 14, 2023
@vishweshbankwar vishweshbankwar marked this pull request as ready for review November 14, 2023 19:41
@vishweshbankwar vishweshbankwar requested a review from a team as a code owner November 14, 2023 19:41
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #5049 (ccc04e9) into main (ecb5dc8) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head ccc04e9 differs from pull request most recent head 4a41a41. Consider uploading reports for the commit 4a41a41 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5049      +/-   ##
==========================================
- Coverage   83.35%   83.34%   -0.02%     
==========================================
  Files         296      296              
  Lines       12474    12473       -1     
==========================================
- Hits        10398    10395       -3     
- Misses       2076     2078       +2     
Flag Coverage Δ
unittests 83.34% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...AspNetCore/Implementation/HttpInMetricsListener.cs 89.39% <ø> (-0.16%) ⬇️

... and 5 files with indirect coverage changes

@@ -118,6 +118,10 @@ Released 2023-Oct-26
definition.
([#4990](https://github.com/open-telemetry/opentelemetry-dotnet/pull/4990))

* `dns.lookups.duration` metric is renamed to `dns.lookup.duration`. This change
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting...there is no code change here. Do we plan to keep updating changelog in otel instrumentation, for every change in .net repo? Or this is a one-time thing and we dont expect anything futher?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mentioned this one because we have a changelog entry in previous release with different name. In future, I don't think we need to mention every change. Except when the change might impact users moving from lower version to net8 or above.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going forward, I think we should simply update the README to point to the Microsoft official docs which lists these metrics and let users track the changes from there.

@utpilla utpilla merged commit 201811a into open-telemetry:main Nov 14, 2023
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants