Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metric bucket override for OpenTelemetry.Instrumentation.AspNet #5063

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

qhris
Copy link
Contributor

@qhris qhris commented Nov 18, 2023

This came up in a PR from the opentelemetry-dotnet-contrib project.

Without this change any user of OpenTelemetry.Instrumentation.AspNet would have to explicitly add a view.

Changes

Updates DefaultHistogramBoundShortMappings to include an override for OpenTelemetry.Instrumentation.AspNet (http.request.server.duration).

Created this PR since @cijothomas suggested this here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Nit suggestion on better changelog wording.

Copy link

codecov bot commented Nov 18, 2023

Codecov Report

Merging #5063 (a7bcfa4) into main (0256f87) will decrease coverage by 0.04%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5063      +/-   ##
==========================================
- Coverage   83.69%   83.66%   -0.04%     
==========================================
  Files         296      296              
  Lines       12484    12485       +1     
==========================================
- Hits        10449    10446       -3     
- Misses       2035     2039       +4     
Flag Coverage Δ
unittests 83.66% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/OpenTelemetry/Metrics/Metric.cs 96.52% <100.00%> (+0.03%) ⬆️

... and 3 files with indirect coverage changes

@utpilla utpilla merged commit 2b62e47 into open-telemetry:main Nov 20, 2023
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants