[ASP.NET Core] Remove OTEL_SEMCONV_STABILITY_OPT_IN #5066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5066 +/- ##
==========================================
- Coverage 83.44% 83.13% -0.32%
==========================================
Files 295 294 -1
Lines 12397 12321 -76
==========================================
- Hits 10345 10243 -102
- Misses 2052 2078 +26
Flags with carried forward coverage won't be shown. Click here to find out more.
|
4 tasks
utpilla
reviewed
Nov 21, 2023
utpilla
reviewed
Nov 21, 2023
| @@ -39,114 +39,106 @@ public IncomingRequestsCollectionsIsAccordingToTheSpecTests(WebApplicationFactor | |||
| } | |||
|
|
|||
| [Theory] | |||
| [InlineData("/api/values", null, "user-agent", 503, "503")] | |||
| [InlineData("/api/values", "?query=1", null, 503, null)] | |||
| [InlineData("/api/values", null, "user-agent", 200, null)] | |||
There was a problem hiding this comment.
Why update the test cases? Do you simply want to add test cases for 200?
There was a problem hiding this comment.
I did not update it in this PR. It was already there, it showing up due to file rename
utpilla
reviewed
Nov 21, 2023
test/OpenTelemetry.Instrumentation.AspNetCore.Tests/MetricTests.cs
Outdated
Show resolved
Hide resolved
utpilla
approved these changes
Nov 21, 2023
… of https://github.com/vishweshbankwar/opentelemetry-dotnet into vibankwa/remove-semantic-conventions-opt-in-aspnetcore
4 tasks
|
nit: I found a comment that's still referencing the older spec. Can this be updated to reference the stable 1.23.0? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Design discussion issue #
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes