Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpClient] Remove OTEL_SEMCONV_STABILITY_OPT_IN #5068

Conversation

vishweshbankwar
Copy link
Member

Fixes #
Design discussion issue #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Merging #5068 (20760cf) into main (2b62e47) will decrease coverage by 0.20%.
Report is 1 commits behind head on main.
The diff coverage is 98.57%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5068      +/-   ##
==========================================
- Coverage   83.69%   83.49%   -0.20%     
==========================================
  Files         296      295       -1     
  Lines       12485    12397      -88     
==========================================
- Hits        10449    10351      -98     
- Misses       2036     2046      +10     
Flag Coverage Δ
unittests 83.49% <98.57%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...elemetry.Instrumentation.Http/HttpClientMetrics.cs 68.75% <100.00%> (-31.25%) ⬇️
...tp/Implementation/HttpHandlerDiagnosticListener.cs 72.79% <100.00%> (-0.72%) ⬇️
...strumentation.Http/Implementation/HttpTagHelper.cs 78.26% <ø> (-6.93%) ⬇️
...plementation/HttpWebRequestActivitySource.netfx.cs 82.26% <100.00%> (-1.58%) ⬇️
...rumentation.Http/MeterProviderBuilderExtensions.cs 100.00% <100.00%> (ø)
...ementation/HttpHandlerMetricsDiagnosticListener.cs 87.03% <95.00%> (-3.11%) ⬇️

... and 7 files with indirect coverage changes

@vishweshbankwar vishweshbankwar marked this pull request as ready for review November 21, 2023 17:06
@vishweshbankwar vishweshbankwar requested a review from a team as a code owner November 21, 2023 17:09
Copy link
Contributor

@rajkumar-rangaraj rajkumar-rangaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Do you want to remove the unused http client based entries from SemanticConventions.cs?

@vishweshbankwar
Copy link
Member Author

LGTM.

Do you want to remove the unused http client based entries from SemanticConventions.cs?

@rajkumar-rangaraj Will do separately: #5071

@@ -275,19 +250,11 @@ public void OnStopActivity(Activity activity, object payload)
activity.SetStatus(SpanHelper.ResolveSpanStatusForHttpStatusCode(activity.Kind, (int)response.StatusCode));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you hardcode the kind to ActivityKind.Client here as well similar to how you have done it for the webrequest one?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in web request we cannot rely on activity being non-null always. here we can, but I can update this one as well later.

@wangzlei
Copy link

@utpilla @rajkumar-rangaraj @vishweshbankwar
Most of vendors' exporter in OTel Collector are still not support translate new http attributes, could you help understand how do we avoid the breaking if no environment variable OTEL_SEMCONV_STABILITY_OPT_IN support ?

@vishweshbankwar
Copy link
Member Author

@utpilla @rajkumar-rangaraj @vishweshbankwar Most of vendors' exporter in OTel Collector are still not support translate new http attributes, could you help understand how do we avoid the breaking if no environment variable OTEL_SEMCONV_STABILITY_OPT_IN support ?

@wangzlei Please refer to FAQ of this announcement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants