[Instrumentation.GrpcNetClient] Support only stable HTTP semantic convention #5259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kielek
changed the title
Kielek
force-pushed
the
grpncnetclient-drop-supporto-for-old-http-sem-conv
branch
from
388310c
to
01d168b
Compare
Kielek
force-pushed
the
grpncnetclient-drop-supporto-for-old-http-sem-conv
branch
from
01d168b
to
9ca3aaf
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5259 +/- ##
==========================================
- Coverage 83.38% 83.01% -0.37%
==========================================
Files 297 272 -25
Lines 12531 11965 -566
==========================================
- Hits 10449 9933 -516
+ Misses 2082 2032 -50
Flags with carried forward coverage won't be shown. Click here to find out more.
|
cijothomas
reviewed
Jan 26, 2024
reyang
reviewed
Jan 26, 2024
reyang
reviewed
Jan 26, 2024
Co-authored-by: Reiley Yang <reyang@microsoft.com>
|
@reyang, @cijothomas, all comments for changeling handled by Reiley suggestion. |
cijothomas
approved these changes
Jan 26, 2024
reyang
approved these changes
Jan 26, 2024
cijothomas
reviewed
Jan 26, 2024
| @@ -9,6 +9,11 @@ | |||
| [issue](https://github.com/open-telemetry/opentelemetry-dotnet/issues/5092) | |||
| for details and workaround. | |||
| ([#5077](https://github.com/open-telemetry/opentelemetry-dotnet/pull/5077)) | |||
| * Removed `OTEL_SEMCONV_STABILITY_OPT_IN` environment variable support. The | |||
There was a problem hiding this comment.
One question .. The grpc conventions are still not stable and this instrumentaion is still emitting them. Should we explicitly call it out, to avoid giving the feel that the entire conventions emitted by this is stable?
There was a problem hiding this comment.
I think it's fine, folks who want to spend time reading changelog should already know semver2.
alanwest
approved these changes
Jan 27, 2024
Co-authored-by: Alan West <3676547+alanwest@users.noreply.github.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # N/A
Design discussion issue # N/A
Changes
Drop support for old semantic convention in GrpcNetClient instrumenation
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes[ ] Changes in public API reviewed (if applicable)