Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.SqlClient] Stop emitting db.statement_type attribute #5301

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Feb 1, 2024

Fixes #
Design discussion issue #

Changes

[Instrumentation.SqlClient] Stop emitting db.statement_type attribute.
It was introduced in https://github.com/open-telemetry/opentelemetry-dotnet/pull/761/files#r450626620. It is not part of semantic convention. I didn't find any other occurrence for this except open-telemetry/opentelemetry-dotnet-contrib#1559

As a separate work, we should consider adding db.operation/sanitizing db.statement.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable) N/A

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (6250307) 83.38% compared to head (fbf5ccf) 83.06%.
Report is 57 commits behind head on main.

❗ Current head fbf5ccf differs from pull request most recent head 1fb9863. Consider uploading reports for the commit 1fb9863 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5301      +/-   ##
==========================================
- Coverage   83.38%   83.06%   -0.32%     
==========================================
  Files         297      272      -25     
  Lines       12531    11971     -560     
==========================================
- Hits        10449     9944     -505     
+ Misses       2082     2027      -55     
Flag Coverage Δ
unittests ?
unittests-Instrumentation-Experimental 24.64% <47.22%> (?)
unittests-Instrumentation-Stable 24.64% <47.22%> (?)
unittests-Solution-Experimental 83.05% <77.41%> (?)
unittests-Solution-Stable 83.06% <77.41%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
....Api/Context/Propagation/TraceContextPropagator.cs 90.00% <100.00%> (+0.52%) ⬆️
...etryProtocol/Implementation/ExperimentalOptions.cs 100.00% <ø> (ø)
...tation/OpenTelemetryProtocolExporterEventSource.cs 100.00% <100.00%> (ø)
...rotocol/Implementation/OtlpLogRecordTransformer.cs 95.41% <100.00%> (+1.95%) ⬆️
...tation.AspNetCore/Implementation/HttpInListener.cs 89.79% <100.00%> (+0.21%) ⬆️
...AspNetCore/Implementation/HttpInMetricsListener.cs 89.74% <100.00%> (+0.26%) ⬆️
...ntation.GrpcNetClient/GrpcClientInstrumentation.cs 100.00% <100.00%> (ø)
...NetClient/GrpcClientTraceInstrumentationOptions.cs 100.00% <ø> (ø)
...ent/Implementation/GrpcClientDiagnosticListener.cs 75.80% <100.00%> (-2.77%) ⬇️
...n.GrpcNetClient/TracerProviderBuilderExtensions.cs 100.00% <100.00%> (ø)
... and 13 more

... and 32 files with indirect coverage changes

@Kielek Kielek changed the title [Instrumentation.SqlClient] Stop emitting db.statement_type attribute. [Instrumentation.SqlClient] Stop emitting db.statement_type attribute Feb 1, 2024
@Kielek Kielek marked this pull request as ready for review February 1, 2024 08:44
@Kielek Kielek requested a review from a team as a code owner February 1, 2024 08:44
@CodeBlanch CodeBlanch merged commit a31bca8 into open-telemetry:main Feb 5, 2024
49 checks passed
@Kielek Kielek deleted the instrumentation-sqlclient-drop-db.statement_type branch February 5, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants