Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo] Bump MinVer to 5.0.0 #5490

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Mar 29, 2024

Propagates changes from open-telemetry/opentelemetry-dotnet-contrib#1633

Changes

Bump MinVer to 5.0.0 - itnernal package.
Breaking changes seems to be no bad impact on OTel packages.~

Upgraded in AutoInstrumentaiton repo some time ago. No issues so far.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • [ ] Unit tests added/updated
  • [ ] Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@Kielek Kielek requested a review from a team as a code owner March 29, 2024 09:42
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.47%. Comparing base (6250307) to head (491e011).
Report is 151 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5490      +/-   ##
==========================================
+ Coverage   83.38%   85.47%   +2.09%     
==========================================
  Files         297      290       -7     
  Lines       12531    12608      +77     
==========================================
+ Hits        10449    10777     +328     
+ Misses       2082     1831     -251     
Flag Coverage Δ
unittests ?
unittests-Instrumentation-Experimental 24.19% <ø> (?)
unittests-Instrumentation-Stable 24.21% <ø> (?)
unittests-Solution-Experimental 85.48% <ø> (?)
unittests-Solution-Stable 85.44% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 64 files with indirect coverage changes

@CodeBlanch CodeBlanch added the infra Infra work - CI/CD, code coverage, linters label Mar 29, 2024
@CodeBlanch CodeBlanch changed the title Bump MinVer to 5.0.0 [repo] Bump MinVer to 5.0.0 Mar 29, 2024
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch merged commit d64318f into open-telemetry:main Mar 29, 2024
49 checks passed
@Kielek Kielek deleted the bump-minver-5.0.0 branch March 29, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Infra work - CI/CD, code coverage, linters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants