Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus] Fixed a race condition happening in simultaneous OpenMetrics and PlainText requests #5517

Closed
wants to merge 31 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
c1af823
Reset cached target info cursor when OpenMetricsRequested is false
hez2010 Apr 8, 2024
1c843d0
Add tests and fix race condition
hez2010 Apr 9, 2024
224d1bd
Add CHANGELOG
hez2010 Apr 9, 2024
677b121
Oops
hez2010 Apr 9, 2024
90c348c
Merge branch 'main' into fix/prometheus_cursor
vishweshbankwar Apr 9, 2024
6e5549f
Apply code suggestion
hez2010 Apr 9, 2024
286d23d
Fix the race condition and add parallel tests
hez2010 Apr 11, 2024
7df9d9c
Update CHANGELOG.md
hez2010 Apr 11, 2024
c2e10df
Merge branch 'main' into fix/prometheus_cursor
hez2010 Apr 11, 2024
0e2551a
Unsubscribe from OnCollect in dtor
hez2010 Apr 11, 2024
00149ef
more fixes
hez2010 Apr 11, 2024
3558e9f
Return two views to simplify the implementation
hez2010 Apr 11, 2024
cb95766
Revert changes to PrometheusExporter
hez2010 Apr 11, 2024
19ae570
Reuse HttpClient in tests
hez2010 Apr 11, 2024
63f32d6
Fix incorrect CompareExchange
hez2010 Apr 11, 2024
7ee3712
Make test faster and add timeout
hez2010 Apr 11, 2024
580257e
Fix linefeeds and add volatile
hez2010 Apr 11, 2024
fb54fc8
Fix markdown
hez2010 Apr 11, 2024
7b3b31e
Merge branch 'main' into fix/prometheus_cursor
CodeBlanch Apr 12, 2024
033148c
Merge branch 'main' into fix/prometheus_cursor
vishweshbankwar Apr 17, 2024
aaf7e43
Adding TODO and CHANGELOG
hez2010 Apr 18, 2024
017dd39
Merge branch 'main' into fix/prometheus_cursor
CodeBlanch Apr 18, 2024
2804a7d
fix lf
hez2010 Apr 19, 2024
fd01eb2
Merge branch 'fix/prometheus_cursor' of github.com:hez2010/openteleme…
hez2010 Apr 19, 2024
665e390
Merge branch 'main' into fix/prometheus_cursor
reyang Apr 19, 2024
45dadb2
Rework the metrics collection
hez2010 Apr 19, 2024
3ee6067
Use CompareExchange
hez2010 Apr 19, 2024
d930f97
Fix invalid assert
hez2010 Apr 20, 2024
0269b93
Fix fromCache
hez2010 Apr 20, 2024
3e003f8
Add an assert
hez2010 Apr 20, 2024
aed502c
typo
hez2010 Apr 20, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,10 @@ private ExportResult OnCollect(Batch<Metric> metrics)
}
}
}
else
{
this.targetInfoBufferLength = -1;
hez2010 marked this conversation as resolved.
Show resolved Hide resolved
}

foreach (var metric in metrics)
{
Expand Down