-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs-metrics] Remove predicate-based View examples #5554
[docs-metrics] Remove predicate-based View examples #5554
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5554 +/- ##
==========================================
+ Coverage 83.38% 85.55% +2.17%
==========================================
Files 297 289 -8
Lines 12531 12493 -38
==========================================
+ Hits 10449 10689 +240
+ Misses 2082 1804 -278
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@alanwest Please review. We have discussed the potential pitfalls from View long ago!
Will having less/no documentation help with that? If we don't want to show this most places I'm fine with that. But IMO we should have an advanced doc/section that at least calls out the potential pitfalls for anyone who chooses to use it. |
I think that's the right direction. Eventually we might want to deprecate this API, and if there are good number of users who need certain feature, another better API might be introduced which doesn't have this callback pattern. |
Most users got it wrong, and the error is not detected/reported at SDK initialization time (the exceptions simply got swallowed) which makes it a big pit of failures.