Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.Http] Move to contrib repository #5574

Merged
merged 11 commits into from Apr 29, 2024

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Apr 26, 2024

Towards: #5526
Related to: open-telemetry/opentelemetry-dotnet-contrib#1694

Changes

[Instrumentation.Http] Move to contrib repository

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • [ ] Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.68%. Comparing base (6250307) to head (36dc8dd).
Report is 200 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5574      +/-   ##
==========================================
+ Coverage   83.38%   85.68%   +2.30%     
==========================================
  Files         297      271      -26     
  Lines       12531    11376    -1155     
==========================================
- Hits        10449     9748     -701     
+ Misses       2082     1628     -454     
Flag Coverage Δ
unittests ?
unittests-Instrumentation-Experimental 87.50% <ø> (?)
unittests-Instrumentation-Stable 87.50% <ø> (?)
unittests-Solution-Experimental 85.38% <ø> (?)
unittests-Solution-Stable 85.66% <ø> (?)
unittests-Unstable-Core 19.87% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...cNetClient/HttpRequestMessageContextPropagation.cs 0.00% <ø> (ø)

... and 98 files with indirect coverage changes

@Kielek Kielek marked this pull request as ready for review April 26, 2024 21:12
@Kielek Kielek requested a review from a team as a code owner April 26, 2024 21:12
@CodeBlanch CodeBlanch merged commit e2a867f into open-telemetry:main Apr 29, 2024
57 checks passed
@Kielek Kielek deleted the migrate-http-instrumentation branch April 29, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants