Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo] Release process tweaks & improvements #5584

Merged
merged 6 commits into from
May 1, 2024

Conversation

CodeBlanch
Copy link
Member

Changes

  • Trigger the build+pack workflow on tag pushes instead of release creation
  • Automatically create GitHub draft release after the MyGet push

Details

We have a quirk in the release process today where we create the GitHub release to trigger the build. The actual packages don't get pushed to NuGet until much later. This creates confusion for users who see the release but don't find the packages. In order to smooth this out, we now trigger the build+pack workflow on the tag push. The GitHub release is now also automatically created as a draft so whoever is doing a release need only publish that release when the packages are available. The content of the release is automatically generated with links to NuGet & the CHANGELOGs which is what we do on contrib. The net is there is less manual work in the release process.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)

@CodeBlanch CodeBlanch added the infra Infra work - CI/CD, code coverage, linters label Apr 30, 2024
@CodeBlanch CodeBlanch requested a review from a team as a code owner April 30, 2024 20:50
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.64%. Comparing base (6250307) to head (ced773c).
Report is 203 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5584      +/-   ##
==========================================
+ Coverage   83.38%   85.64%   +2.26%     
==========================================
  Files         297      271      -26     
  Lines       12531    11376    -1155     
==========================================
- Hits        10449     9743     -706     
+ Misses       2082     1633     -449     
Flag Coverage Δ
unittests ?
unittests-Instrumentation-Experimental 87.50% <ø> (?)
unittests-Instrumentation-Stable 87.50% <ø> (?)
unittests-Solution-Experimental 85.63% <ø> (?)
unittests-Solution-Stable 85.58% <ø> (?)
unittests-Unstable-Core 19.87% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 101 files with indirect coverage changes

@CodeBlanch CodeBlanch merged commit eace49c into open-telemetry:main May 1, 2024
57 checks passed
@CodeBlanch CodeBlanch deleted the repo-release-tweaks branch May 1, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Infra work - CI/CD, code coverage, linters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants