Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zipkin] Switch to TagWriter for handling of tags/attributes #5590

Merged
merged 4 commits into from
May 7, 2024

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented May 3, 2024

Follow-up to #5476
Relates to #5475

Changes

  • Switch from TagTransformer to TagWriter design in ZipkinExporter project

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes

Copy link

codecov bot commented May 3, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 85.65%. Comparing base (6250307) to head (02bad89).
Report is 206 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5590      +/-   ##
==========================================
+ Coverage   83.38%   85.65%   +2.27%     
==========================================
  Files         297      271      -26     
  Lines       12531    11377    -1154     
==========================================
- Hits        10449     9745     -704     
+ Misses       2082     1632     -450     
Flag Coverage Δ
unittests ?
unittests-Solution-Experimental 85.65% <62.50%> (?)
unittests-Solution-Stable 85.38% <62.50%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...metry.Exporter.Zipkin/Implementation/ZipkinSpan.cs 96.15% <50.00%> (+1.15%) ⬆️
....Exporter.Zipkin/Implementation/ZipkinTagWriter.cs 63.63% <63.63%> (ø)

... and 99 files with indirect coverage changes

@CodeBlanch CodeBlanch merged commit 2fe54ee into open-telemetry:main May 7, 2024
33 checks passed
@CodeBlanch CodeBlanch deleted the zipkin-tagwriter branch May 7, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants