Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk] Expose the ctor on Batch<T> which accepts a single item #5642

Closed

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented May 21, 2024

To help resolve: open-telemetry/opentelemetry-dotnet-contrib#1814

Changes

  • Expose the ctor on Batch<T> which accepts a single item for the batch.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@CodeBlanch CodeBlanch added the pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package label May 21, 2024
@CodeBlanch CodeBlanch requested a review from a team as a code owner May 21, 2024 23:37
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.67%. Comparing base (6250307) to head (5935c0b).
Report is 250 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5642      +/-   ##
==========================================
+ Coverage   83.38%   85.67%   +2.29%     
==========================================
  Files         297      254      -43     
  Lines       12531    11037    -1494     
==========================================
- Hits        10449     9456     -993     
+ Misses       2082     1581     -501     
Flag Coverage Δ
unittests ?
unittests-Solution-Experimental 85.64% <100.00%> (?)
unittests-Solution-Stable 85.67% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/OpenTelemetry/Batch.cs 96.18% <100.00%> (-1.36%) ⬇️

... and 113 files with indirect coverage changes

@CodeBlanch CodeBlanch marked this pull request as draft May 22, 2024 00:04
@CodeBlanch
Copy link
Member Author

@reyang is going to explore doing something with attributes to allow users to opt-into having SimpleExportProcessor switch into a reentrant/non-blocking mode. Going to keep this in draft to give him time to investigate that and then we can decide which direction to take.

@reyang
Copy link
Member

reyang commented May 22, 2024

I have a different idea how to solve this (and a category of similar problems), check #5643.

Copy link
Contributor

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions bot added Stale and removed Stale labels May 29, 2024
Copy link
Contributor

github-actions bot commented Jun 6, 2024

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions bot added the Stale label Jun 6, 2024
Copy link
Contributor

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GenevaExporter uses Expression.Lambda from System.Linq.Expressions - AOT size and performance concerns
3 participants