Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic benchmark project for Activity based SDK. #725

Merged
merged 2 commits into from Jun 12, 2020
Merged

Add basic benchmark project for Activity based SDK. #725

merged 2 commits into from Jun 12, 2020

Conversation

cijothomas
Copy link
Member

@cijothomas cijothomas commented Jun 12, 2020

Towards 8a from #684

Changes

Added a basic benchmarking project.
Will build on this afterwards.

Checklist

  • I ran Unit Tests locally.

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public API reviewed

The PR will automatically request reviews from code owners and trigger CI build and tests.

@@ -21,6 +21,9 @@ internal static class Program
{
public static void Main(string[] args)
{
// examples to run from command line:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably put this in a simple README.md file?

Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cijothomas cijothomas merged commit fa69fb0 into open-telemetry:master Jun 12, 2020
@cijothomas cijothomas deleted the cijothomas/activitybenchmark1 branch June 12, 2020 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants