Skip to content
This repository has been archived by the owner on Oct 26, 2020. It is now read-only.

Fix issues-48 #56

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Fix issues-48 #56

merged 1 commit into from
Jun 2, 2020

Conversation

yatender-oktalk
Copy link
Contributor

  • OpenTelemetry removing /" and replacing this with
    " as it creates confusion.
  • Updated the example doc for the new API updates.

Modified OpenTelemetry.Span
Following changes were done.

  • Changes related to documentation example add_event
  • Updated add_event/1 to add_event/2 to accept
    event_name and event_attributes.

@yatender-oktalk
Fix issues/48
b7f6daa 
- OpenTelemetry removing `/"` and  replacing this with
`"` as it creates confusion.
- Updated the example doc for the new API updates.

Modified `OpenTelemetry.Span`
Following changes were done.

- Changes related to documentation example `add_event`
- Updated `add_event/1` to `add_event/2` to accept
`event_name` and `event_attributes`.
@yatender-oktalk yatender-oktalk requested a review from a team as a code owner June 2, 2020 08:14
@tsloughter
Copy link
Member

Thanks! Do the docs generate and render correctly without the quoted strings? I could have swore I would have added those for a reason...

@yatender-oktalk
Copy link
Contributor Author

yatender-oktalk commented Jun 2, 2020 via email

@tsloughter
Copy link
Member

Ok, thanks!

@tsloughter tsloughter merged commit 387f233 into open-telemetry:master Jun 2, 2020
@tolbrino tolbrino mentioned this pull request Jul 9, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tsloughter tsloughter tsloughter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yatender-oktalk @tsloughter