Skip to content

Commit

Permalink
add SDK and API deps to the exporter rebar.config
Browse files Browse the repository at this point in the history
  • Loading branch information
tsloughter committed Nov 16, 2020
1 parent be90b94 commit 2e9c432
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
7 changes: 5 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,15 @@ Applications can be used.
``` elixir
{:opentelemetry_api, github: "open-telemetry/opentelemetry-erlang", sparse:
"apps/opentelemetry_api", override: true},
{:opentelemetry, github: "open-telemetry/opentelemetry-erlang", sparse: "apps/opentelemetry"},
{:opentelemetry, github: "open-telemetry/opentelemetry-erlang", sparse: "apps/opentelemetry", override: true},
```

The `override: true` is required because the SDK Application, `opentelemetry`, has
the API in its `deps` list of its `rebar.config` as a hex dependency and this will
clash when `mix` tries to resolve the dependencies and fail without the override.
clash when `mix` tries to resolve the dependencies and fail without the
override. `override: true` is also used on the SDK because the
`opentelemetry_exporter` application depends on it and the API as hex deps so if
it is included the override is necessary.

### Including in Release

Expand Down
4 changes: 3 additions & 1 deletion apps/opentelemetry_exporter/rebar.config
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
{erl_opts, [debug_info]}.
{deps, [grpcbox]}.
{deps, [grpcbox,
opentelemetry,
opentelemetry_api]}.

{grpc, [{protos, ["opentelemetry-proto/opentelemetry/proto/collector/trace/v1"]},
{gpb_opts, [{module_name_prefix, "opentelemetry_exporter_"},
Expand Down

0 comments on commit 2e9c432

Please sign in to comment.