Merge pull request #145 from tsloughter/fix-add-event

fix add_event macro to call otel_span:add_event/3
open-telemetry · Nov 15, 2020 · b5e6b65 · b5e6b65
2 parents 1d5a5a0 + e9576bc
commit b5e6b65
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/apps/opentelemetry_api/include/otel_tracer.hrl b/apps/opentelemetry_api/include/otel_tracer.hrl
@@ -33,8 +33,8 @@
 -define(set_attributes(Attributes),
         otel_span:set_attributes(?current_span_ctx, Attributes)).
 
--define(add_event(Event),
-        otel_span:add_event(?current_span_ctx, Event)).
+-define(add_event(Name, Attributes),
+        otel_span:add_event(?current_span_ctx, Name, Attributes)).
 
 -define(add_events(Events),
         otel_span:add_events(?current_span_ctx, Events)).

diff --git a/apps/opentelemetry_api/test/opentelemetry_api_SUITE.erl b/apps/opentelemetry_api/test/opentelemetry_api_SUITE.erl
@@ -115,6 +115,7 @@ update_span_data(_Config) ->
     ?set_current_span(SpanCtx1),
 
     ?set_attribute(<<"key-1">>, <<"value-1">>),
+    ?add_event(<<"event-1">>, [{<<"attr-1">>, <<"value-1">>}]),
 
     Events = opentelemetry:events([{opentelemetry:timestamp(),
                                     <<"timed-event-name">>, []}]),