Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update protos #139

Merged
merged 3 commits into from
Nov 7, 2020
Merged

update protos #139

merged 3 commits into from
Nov 7, 2020

Conversation

tsloughter
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #139 into master will decrease coverage by 0.22%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
- Coverage   32.46%   32.24%   -0.23%     
==========================================
  Files          63       62       -1     
  Lines        2991     3145     +154     
==========================================
+ Hits          971     1014      +43     
- Misses       2020     2131     +111     
Flag Coverage Δ
api 49.44% <ø> (+2.35%) ⬆️
elixir 17.67% <ø> (+1.47%) ⬆️
erlang 32.09% <100.00%> (-0.23%) ⬇️
exporter 18.02% <100.00%> (+0.96%) ⬆️
sdk 65.11% <ø> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apps/opentelemetry_api/src/opentelemetry.erl 67.18% <ø> (ø)
...pps/opentelemetry_api/src/otel_tracer_provider.erl 48.00% <ø> (ø)
...er/src/opentelemetry_exporter_trace_service_pb.erl 15.83% <ø> (+1.01%) ⬆️
...ntelemetry_exporter/src/opentelemetry_exporter.erl 75.00% <100.00%> (+13.88%) ⬆️
apps/opentelemetry/src/otel_batch_processor.erl 72.72% <0.00%> (-2.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcd5467...fb94a12. Read the comment docs.

Copy link
Member

@ferd ferd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this come with a git submodule update though? I guess that stuff isn't locked anyway.

@tsloughter
Copy link
Member Author

Huh, yea, it also doesn't seem to have updated it to the commit I wanted. I'm going to figure this out and include fix to status code that comes with the latest protos.

@tsloughter tsloughter merged commit 0e448fd into open-telemetry:master Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants