Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rebar dep #146

Merged
merged 4 commits into from
Nov 16, 2020
Merged

Add rebar dep #146

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d84475d
add opentelemetry_api to rebar.config of sdk app
tsloughter Nov 16, 2020
c39bf9f
update readme to use override for API dep
tsloughter Nov 16, 2020
be90b94
fix api dep in top level mix.exs used for tests
tsloughter Nov 16, 2020
2e9c432
add SDK and API deps to the exporter rebar.config
tsloughter Nov 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,14 @@ Applications can be used.

``` elixir
{:opentelemetry_api, github: "open-telemetry/opentelemetry-erlang", sparse:
"apps/opentelemetry_api"},
"apps/opentelemetry_api", override: true},
{:opentelemetry, github: "open-telemetry/opentelemetry-erlang", sparse: "apps/opentelemetry"},
```

The `override: true` is required because the SDK Application, `opentelemetry`, has
the API in its `deps` list of its `rebar.config` as a hex dependency and this will
clash when `mix` tries to resolve the dependencies and fail without the override.

### Including in Release

In an Erlang project add `opentelemetry` as the first element of the release's applications:
Expand Down
2 changes: 1 addition & 1 deletion apps/opentelemetry/rebar.config
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
{erl_opts, [debug_info]}.
{deps, []}.
{deps, [opentelemetry_api]}.