Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crosslink: Fix Windows produces backslashes instead of slashes #459

Merged

Conversation

scorpionknifes
Copy link
Member

Fixes: #458

Unit tests for crosslink now pass on Windows. (no changes in tests required)

opentelemetry-go-build-tools\crosslink>go test ./...
?       go.opentelemetry.io/build-tools/crosslink       [no test files]
ok      go.opentelemetry.io/build-tools/crosslink/cmd   0.085s
ok      go.opentelemetry.io/build-tools/crosslink/internal      0.204s

Copy link

codecov bot commented Dec 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (de501c5) 63.65% compared to head (3dd1561) 63.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #459      +/-   ##
==========================================
+ Coverage   63.65%   63.68%   +0.03%     
==========================================
  Files          39       39              
  Lines        2259     2261       +2     
==========================================
+ Hits         1438     1440       +2     
  Misses        677      677              
  Partials      144      144              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mx-psi mx-psi merged commit 8081a8c into open-telemetry:main Dec 11, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crosslink: on Windows it produces backslashes instead of slashes
4 participants