New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jaeger.sampler.UpdateSampler() log output #2259

Open

tttoad opened this issue May 4, 2022 · 1 comment

Labels

enhancement sampler: jaegerremote

Contributor

tttoad commented May 4, 2022

Background

The log output statement in the UpdateSampler function is commented out.

Proposed Solution

Maybe we can use the otel.Handle function to print the log

Contributor Author

tttoad commented May 11, 2022

In code https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/samplers/jaegerremote/sampler_remote.go#L149 , the output of the log is commented out...
The log should be output.

tttoad mentioned this issue

Add logging options to jaeger.sampler #2566

Merged

MrAlias added enhancement sampler: jaegerremote labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment