Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not assume "aws" partition in ecs detector. Fixes #3166 #3167

Merged
merged 1 commit into from Feb 23, 2023

Conversation

ahobson
Copy link
Contributor

@ahobson ahobson commented Jan 18, 2023

No description provided.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 18, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: ahobson / name: Andrew Hobson (f9af75f)

@ahobson
Copy link
Contributor Author

ahobson commented Jan 31, 2023

I have updated the PR with fixes for the linting problems

@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #3167 (64054fc) into main (d296842) will increase coverage by 0.1%.
The diff coverage is 85.7%.

❗ Current head 64054fc differs from pull request most recent head 6f573b3. Consider uploading reports for the commit 6f573b3 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3167     +/-   ##
=======================================
+ Coverage   69.6%   69.7%   +0.1%     
=======================================
  Files        147     147             
  Lines       6919    6905     -14     
=======================================
- Hits        4821    4819      -2     
+ Misses      1978    1961     -17     
- Partials     120     125      +5     
Impacted Files Coverage Δ
detectors/aws/ecs/ecs.go 39.6% <85.7%> (+21.6%) ⬆️
samplers/jaegerremote/sampler_remote.go 87.4% <0.0%> (-2.3%) ⬇️
...ation/github.com/gin-gonic/gin/otelgin/gintrace.go 82.5% <0.0%> (-1.0%) ⬇️
...ntation/github.com/gin-gonic/gin/otelgin/option.go 100.0% <0.0%> (ø)
...om/aws/aws-sdk-go-v2/otelaws/dynamodbattributes.go 100.0% <0.0%> (ø)

@ahobson
Copy link
Contributor Author

ahobson commented Feb 17, 2023

Is there anything else I can do to help get this merged? It passes tests and lints for me locally

Copy link
Member

@Aneurysm9 Aneurysm9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a CHANGELOG entry.

@Aneurysm9 Aneurysm9 linked an issue Feb 21, 2023 that may be closed by this pull request
@ahobson ahobson force-pushed the adh-arn-split branch 2 times, most recently from acbdaf6 to 0f186a4 Compare February 21, 2023 19:29
@ahobson
Copy link
Contributor Author

ahobson commented Feb 21, 2023

@Aneurysm9 Thank you for the feedback! I've updated the PR

CHANGELOG.md Outdated Show resolved Hide resolved
Aneurysm9

This comment was marked as resolved.

@ahobson
Copy link
Contributor Author

ahobson commented Feb 22, 2023

😊 I apologize for updating the Makefile, changes reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws ecs detector panics in AWS govcloud
3 participants