New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not assume "aws" partition in ecs detector. Fixes #3166 #3167
Conversation
|
I have updated the PR with fixes for the linting problems |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3167 +/- ##
=======================================
+ Coverage 69.6% 69.7% +0.1%
=======================================
Files 147 147
Lines 6919 6905 -14
=======================================
- Hits 4821 4819 -2
+ Misses 1978 1961 -17
- Partials 120 125 +5
|
01a6ac6
to
6055125
Compare
6055125
to
2cb48c9
Compare
Is there anything else I can do to help get this merged? It passes tests and lints for me locally |
2cb48c9
to
12a44b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a CHANGELOG entry.
acbdaf6
to
0f186a4
Compare
@Aneurysm9 Thank you for the feedback! I've updated the PR |
0f186a4
to
2fc9770
Compare
2fc9770
to
93c4cef
Compare
😊 I apologize for updating the Makefile, changes reverted. |
93c4cef
to
6f573b3
Compare
No description provided.