Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Add propagation through RabbitMQ messages #376

Open
nchandran3 opened this issue Sep 29, 2020 · 2 comments
Open

Question: Add propagation through RabbitMQ messages #376

nchandran3 opened this issue Sep 29, 2020 · 2 comments
Labels
area: propagators Related to the propagators module enhancement New feature or request question Further information is requested

Comments

@nchandran3
Copy link

Is it possible / advisable to add propagation logic for RabbitMQ messages, much like HTTPInjectors / HTTPExtractors.

If so, interested in contributing these.

@Aneurysm9 Aneurysm9 transferred this issue from open-telemetry/opentelemetry-go Sep 29, 2020
@Aneurysm9
Copy link
Member

I've moved this issue to the opentelemetry-go-contrib repo as that is where such instrumentation would live. Instrumentation for non-HTTP message-based systems is definitely desirable. You can take a look at the Sarama instrumentation for an example of how such a system might be integrated with existing TextMap-based propagators. Specifically, here where it sets up wrappers around Kafka message headers to act as Suppliers for the existing propagators. As long as RabbitMQ has a similar header mechanism I'd imagine a similar instrumentation pattern would work.

@MrAlias MrAlias added area: propagators Related to the propagators module enhancement New feature or request release:after-ga labels Sep 30, 2020
@brianmori
Copy link

Indeed @Aneurysm9 , rabbitmq supports headers for each message and they can be used to propagate TraceId and SpanId

@MrAlias MrAlias added question Further information is requested and removed release:after-ga labels Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: propagators Related to the propagators module enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants