Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove otelbeego #4059

Closed
pellared opened this issue Jul 14, 2023 · 3 comments
Closed

Remove otelbeego #4059

pellared opened this issue Jul 14, 2023 · 3 comments
Assignees
Labels
area: instrumentation Related to an instrumentation package enhancement New feature or request instrumentation: otelbeego

Comments

@pellared
Copy link
Member

pellared commented Jul 14, 2023

Problem Statement

The https://github.com/open-telemetry/opentelemetry-go-contrib/tree/main/instrumentation/github.com/astaxie/beego/otelbeego instrumentation library instruments https://pkg.go.dev/github.com/astaxie/beego library that is no longer maintained (old version with security vulns.

The latest version of beego already has some OTel support e.g. https://pkg.go.dev/github.com/beego/beego/v2@v2.1.0/client/httplib/filter/opentelemetry and https://pkg.go.dev/github.com/beego/beego/v2/client/orm/filter/opentelemetry

There was already an issue to add OTel instrumentation into beego: beego/beego#4945. This approach would be more inline with our current recommendation.

Proposed Solution

Deprecate https://github.com/open-telemetry/opentelemetry-go-contrib/tree/main/instrumentation/github.com/astaxie/beego/otelbeego in next release.

Afterwards, as part of a subsequent release, remove the module from codebase and from the OTel Registry (https://opentelemetry.io/ecosystem/registry/adding/)

Additional Context

Add any other context or screenshots about the feature request here.

@pellared pellared added enhancement New feature or request area: instrumentation Related to an instrumentation package instrumentation: otelbeego labels Jul 14, 2023
@MrAlias
Copy link
Contributor

MrAlias commented Jul 14, 2023

Given we never had anyone raise their hand to dedicate themselves as a maintainer:

instrumentation/github.com/astaxie/beego/otelbeego/ @open-telemetry/go-approvers

This seems appropriate to me 👍

@dmathieu
Copy link
Member

👍
And close #1525

@pellared
Copy link
Member Author

Closing per #4295

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: instrumentation Related to an instrumentation package enhancement New feature or request instrumentation: otelbeego
Projects
None yet
Development

No branches or pull requests

3 participants