Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cortex example code #722

Merged
merged 2 commits into from
Mar 29, 2021
Merged

Fix cortex example code #722

merged 2 commits into from
Mar 29, 2021

Conversation

mtanda
Copy link
Contributor

@mtanda mtanda commented Mar 29, 2021

pusher.Stop(ctx) is called immediately after launch, background remote write is not keep running.
I think, it should be wrapped by func() {}().

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 29, 2021 •
edited

CLA Signed

The committers are authorized under a signed CLA.

@MrAlias MrAlias merged commit 5ec7f3c into open-telemetry:main Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

@MrAlias MrAlias MrAlias approved these changes

@XSAM XSAM XSAM approved these changes

@dashpole dashpole Awaiting requested review from dashpole

@evantorrie evantorrie Awaiting requested review from evantorrie

@jmacd jmacd Awaiting requested review from jmacd

@lizthegrey lizthegrey Awaiting requested review from lizthegrey

@paivagustavo paivagustavo Awaiting requested review from paivagustavo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mtanda @Aneurysm9 @MrAlias @XSAM