Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of __buitin_memset in net/http ebpf #826

Open
damemi opened this issue May 8, 2024 · 0 comments
Open

Remove use of __buitin_memset in net/http ebpf #826

damemi opened this issue May 8, 2024 · 0 comments
Milestone

Comments

@damemi
Copy link
Contributor

damemi commented May 8, 2024

Ah I think it's the use of __buitin_memset which can only clear up to 512 bytes. I think to workaround this problem we can avoid using memset and manually set each scalar field to 0 and each character array 0th byte to '\0'. So essentially, manually initialize all fields. It should be less operations too, since we'll be setting a lot less bytes to 0, e.g. maybe 30?

Perhaps this shouldn't hold up the PR, we can follow-up with another change if we wanted to increase the sizes.

Originally posted by @grcevski in #790 (comment)

The url.full attribute for our net/http instrumentation will not fully parse long fields (such as host, path, or query) due to the issue in the linked comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants