Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace bpf_ktime_get_boot_ns calls #22

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

edeNFed
Copy link
Contributor

@edeNFed edeNFed commented Feb 4, 2023

As discussed in the last SIG meeting, using bpf_ktime_get_boot_ns() requires a pretty new version of the kernel.
This PR replaces any invocation of bpf_ktime_get_boot_ns() with bpf_ktime_get_ns() that exists in old kernel versions.

@edeNFed edeNFed requested a review from a team as a code owner February 4, 2023 19:29
Copy link
Member

@dineshg13 dineshg13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add from which Kernel version this method is supported?

@pdelewski
Copy link
Member

Can you please add from which Kernel version this method is supported?

I think it would be good to mention reason of replacement, in the commit message or comment

@MrAlias MrAlias merged commit c37c35d into open-telemetry:main Feb 7, 2023
@MrAlias MrAlias added the help wanted Extra attention is needed label Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants