Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return error if target binary is not set #339

Merged
merged 2 commits into from
Sep 21, 2023
Merged

fix: return error if target binary is not set #339

merged 2 commits into from
Sep 21, 2023

Commits on Sep 21, 2023

  1. fix: return error if target binary is not set 

    If OTEL_GO_AUTO_TARGET_EXE is not defined, a runtime panic is triggered:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x96796c]

goroutine 1 [running]:
go.opentelemetry.io/auto/internal/pkg/process.(*TargetArgs).Validate(...)
    @rogercoll
    rogercoll committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    5a74349 View commit details
    Browse the repository at this point in the history

  2. fix error commen typo 

    Co-authored-by: Przemyslaw Delewski <102958445+pdelewski@users.noreply.github.com>
    @rogercoll @pdelewski
    rogercoll and pdelewski committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    9bdac03 View commit details
    Browse the repository at this point in the history