Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[auto] Update generated offsets #38

Closed
wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link
Contributor

This is an automated PR to update the generated Go field offsets.

@github-actions github-actions bot requested a review from a team as a code owner March 12, 2023 00:18
Copy link
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add CI with a sample app to check that changes (such as the generated offsets) are valid. I don't see an issue for that yet so making one

@edeNFed
Copy link
Contributor

edeNFed commented Mar 14, 2023

Really cool @damemi !

@damemi
Copy link
Contributor

damemi commented Apr 4, 2023

I ended up manually updating the offsets as part of #46, so I'm not sure if this automated change is still relevant. It might not be, based on the conflicts. It also hasn't run against the new e2es.

@MrAlias
Copy link
Contributor

MrAlias commented Apr 4, 2023

I ended up manually updating the offsets as part of #46, so I'm not sure if this automated change is still relevant. It might not be, based on the conflicts. It also hasn't run against the new e2es.

👍

@MrAlias MrAlias closed this Apr 4, 2023
@MrAlias MrAlias deleted the automated/generated-offsets branch April 4, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants