Update jaeger image in getting-started #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
What I did
This updates the Jaeger image in getting-started from
jaegertracing/opentelemetry-all-in-onetojaegertracing/all-in-one.I don't update CHANGELOG.md because this only updates getting-started, but let me know if needed.
Why it needs
I followed the procedure in getting-started to deploy, but the applications of
emojivoto-instrumentedoutput the following error.It worked correctly by changing the Jaeger image from
jaegertracing/opentelemetry-all-in-onetojaegertracing/all-in-one.jaegertracing/opentelemetry-all-in-onehas not been updated for three years.https://hub.docker.com/r/jaegertracing/opentelemetry-all-in-one
OpenTelemetry's Collaborator says don't use
jaegertracing/opentelemetry-all-in-one.open-telemetry/opentelemetry-collector#2558
I think you should use
jaegertracing/all-in-oneused in the examples.https://github.com/hiroyaonoe/opentelemetry-go-instrumentation/blob/7b7c9a69665c472049f15e5f03bdb64db35764e9/examples/httpPlusdb/docker-compose.yaml#L39
https://github.com/hiroyaonoe/opentelemetry-go-instrumentation/blob/7b7c9a69665c472049f15e5f03bdb64db35764e9/examples/rolldice/docker-compose.yaml#L37