-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't track outgoing span contexts with the context map #873
base: main
Are you sure you want to change the base?
Don't track outgoing span contexts with the context map #873
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice performance fix!
This is still in draft because I'm not sure about the gRPC client probe which is outgoing but makes use of the |
Does this mean we are lacking testing for a particular case? |
No, I meant that the use of |
The
start_tracking_span
andstop_tracking_span
functions are used for in-process context propagation, hence there is no need to call them on outgoing spans.